Skip to content

remove legacy profiler #52624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2023
Merged

remove legacy profiler #52624

merged 3 commits into from
Apr 10, 2023

Conversation

zoooo0820
Copy link
Contributor

@zoooo0820 zoooo0820 commented Apr 7, 2023 •
edited
Loading

PR types

Others

PR changes

APIs

Describe

Pcard-67005

This PR is the following part of #50133

remove legacy profiler apis, including following apis:
paddle.fluid.profiler.*
paddle.utils.profiler.*

After this change, users are recommended to use new profiler paddle.profiler

@paddle-bot
Copy link

paddle-bot bot commented Apr 7, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

kangguangli
kangguangli approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@kangguangli kangguangli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for deletion of test_parallel_executor_profiler.py

XieYunshen
XieYunshen approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
单测删除

jeff41404
jeff41404 approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sunzhongkai588
sunzhongkai588 approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff41404 jeff41404 merged commit 0b89cb1 into PaddlePaddle:develop Apr 10, 2023
@zoooo0820 zoooo0820 deleted the rm_old_profiler branch April 10, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@jeff41404 jeff41404 jeff41404 approved these changes

@kangguangli kangguangli kangguangli approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zoooo0820 @luotao1 @jeff41404 @kangguangli @XieYunshen @sunzhongkai588